Alona Kaplan has posted comments on this change. Change subject: webadmin, userportal: logical network editor ......................................................................
Patch Set 9: (1 inline comment) I still don't see the "null" network in the network list of the vnic (even the cluster version supports it). Previously the problem was just in the vm->vnic add/edit dialog. Now the vm dialog also doesn't have the "null" network... .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java Line 1: package org.ovirt.engine.ui.uicommonweb.models.vms; Line 2: Line 3: import java.util.ArrayList; Line 4: import java.util.Arrays; This import causes a checkstyle error- ovirt-engine/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java:4:8: Unused import - java.util.Arrays Line 5: import java.util.List; Line 6: Line 7: import org.ovirt.engine.core.common.businessentities.DisplayType; Line 8: import org.ovirt.engine.core.common.businessentities.StorageDomain; -- To view, visit http://gerrit.ovirt.org/15102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a5b488236ba5a08fc9050ed13a6ed49802769da Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
