Roy Golan has posted comments on this change.
Change subject: utils: enable UT for EngineLocalConfig
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtilsTest.java
Line 27: config.put("ENGINE_PKI_TRUST_STORE_PASSWORD",
keystorePassword);
Line 28: config.put("ENGINE_PKI_ENGINE_STORE", keystore);
Line 29: config.put("ENGINE_PKI_ENGINE_STORE_PASSWORD",
keystorePassword);
Line 30: config.put("ENGINE_PKI_ENGINE_STORE_ALIAS", "1");
Line 31: EngineLocalConfig.getInstance(config);
but the getInstance(Map values) is for testing purposes so every init in tests
should be done with it.
To me the clear method seems redundant. Either each test will call
getInstance(values) or the @AfterClass treatment will call
getInstance(Collections.emptyMap()))
Line 32: }
Line 33:
Line 34: @Test
Line 35: public void testEncrypt() throws Exception {
--
To view, visit http://gerrit.ovirt.org/16183
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie877a056e11a83badd5675cf24ffa48898b5786d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
