Yair Zaslavsky has posted comments on this change.

Change subject: [WIP]core: Provide a wrapper script with rhevm to...
......................................................................


Patch Set 1: (1 inline comment)

The script itself looks good to me.
I have a question though -
I guess there is no linux hack we can use to prevent running psql by mistake?
Maybe using alternatives?

....................................................
File backend/manager/tools/dbutils/engine-psql.sh
Line 1: #!/bin/bash
Line 2: 
#################################################################################
Line 3: # The purpose of this script is to be a wrapper for GSS data 
manipulations on the
s/GSS/support
Line 4: #   database done up to now by psql.
Line 5: # The script supports all original psql flags and records the executed 
SQL and its
Line 6: #   results in /var/log/ovirt-engine/engine-psql.log
Line 7: # The scripts supports both original -c <sql command> and -f <file>


-- 
To view, visit http://gerrit.ovirt.org/16273
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I468f830196bd95dc013a5142f9aa0d508e687d90
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to