Ori Liel has posted comments on this change.

Change subject: [WIP] API: Adding monitored commands to ...
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
Line 108: import org.ovirt.engine.core.common.queries.VdcQueryReturnValue;
Line 109: import org.ovirt.engine.core.common.queries.VdcQueryType;
Line 110: import org.ovirt.engine.core.compat.NGuid;
Line 111: 
Line 112: public class BackendCapabilitiesResource extends BackendResource 
implements CapabilitiesResource {
Also need to add to here the new enum values that the user may pass.
Line 113: 
Line 114:     private MappingLocator mappingLocator;
Line 115:     private FeaturesHelper featuresHelper = new FeaturesHelper();
Line 116: 


Line 496:         }
Line 497:         return policies;
Line 498:     }
Line 499: 
Line 500:     private MonitoredCommands getMonitoredCommands() {
We need to further discuss this. It's not API language to show the name of the 
engine commands.
Line 501:         MonitoredCommands commands = new MonitoredCommands();
Line 502:         VdcQueryReturnValue ret = 
runQuery(VdcQueryType.GetMonitoredCommands, new VdcQueryParametersBase());
Line 503:         List<String> list = (ArrayList<String>)ret.getReturnValue();
Line 504:         for (String command : list) {


-- 
To view, visit http://gerrit.ovirt.org/16168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaba15e72fa05cd5508139a5fe80567fd95dc7539
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to