Laszlo Hornyak has posted comments on this change.
Change subject: core: prevent HA VM from being non-migratable
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
Line 180: return null;
Line 181: }
Line 182: }
Line 183:
Line 184: static boolean validatePinningAndMigration(List<String> reasons,
VmStatic vmStaticData, String cpuPinning) {
just wanted to note here that this may no longer be an ideal name for the
method, but it's ok to have it next time
Line 185: final boolean cpuPinMigrationEnabled =
Boolean.TRUE.equals(Config.<Boolean>
GetValue(ConfigValues.CpuPinMigrationEnabled));
Line 186: if (!cpuPinMigrationEnabled
Line 187: && vmStaticData.getMigrationSupport() ==
MigrationSupport.MIGRATABLE
Line 188: && StringUtils.isNotEmpty(cpuPinning)) {
--
To view, visit http://gerrit.ovirt.org/16190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a7896ddd829fdd89396057114886acae3d65d10
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
