Ofer Schreiber has posted comments on this change.

Change subject: packaging: spec: stop sysv services when package remove
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File ovirt-engine.spec.in
Line 503: %endif
Line 504: 
Line 505: %if %{install_systemv}
Line 506: if [ $1 -eq 0 ] ; then
Line 507:     service ovirt-engine stop
in any case of failure this will fail rpm removal.
better add " || true" or similar.
Line 508: fi
Line 509: %endif
Line 510: 
Line 511: %postun


-- 
To view, visit http://gerrit.ovirt.org/16215
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I909dc0b5062bf76bf19ab535bac548473184a21b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to