Sahina Bose has posted comments on this change.
Change subject: Using ssh username and password to install and update host
......................................................................
Patch Set 12: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 318: } else if
(!ValidationUtils.validatePort(vds.getSSHPort())) {
Line 319: returnValue =
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VDS_WITH_INVALID_SSH_PORT);
Line 320: } else if ((vds.getSSHUsername() == null) ||
Line 321: vds.getSSHUsername().isEmpty() ||
Line 322: (vds.getSSHUsername().length() >
BusinessEntitiesDefinitions.HOST_HOSTNAME_SIZE)) {
Should ssh username length be compared to hostname length?
Line 323: returnValue =
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VDS_WITH_INVALID_SSH_USERNAME);
Line 324: } else {
Line 325: returnValue = returnValue &&
validateSingleHostAttachedToLocalStorage();
Line 326:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 838: public void execute() throws Exception {
Line 839: InputStream in = null;
Line 840: try {
Line 841: _dialog.setHost(_vds.getHostName(), _vds.getSSHPort());
Line 842: setUser(_vds.getSSHUsername());
Shouldn't _dialog.setUser be called here, and the method setUser removed as
we're going to get username from _vds always?
Line 843: _dialog.connect();
Line 844: _messages.post(
Line 845: InstallerMessages.Severity.INFO,
Line 846: String.format(
--
To view, visit http://gerrit.ovirt.org/16006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39914e1286870373ad6f69360fa7b3ddfabd8df
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
