Arik Hadas has posted comments on this change.
Change subject: core: avoid NPE on RemoveDiskCommand (floating disk)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 356: if (getDisk() == null) {
Line 357: return null;
Line 358: }
Line 359:
Line 360: if (getDisk().getVmEntityType() != null) {
yeah, I didn't think about this.. but don't you prefer to add it to the first
clause (i mean to check in line 356) that: getDisk() == null ||
getDisk().getVmEntityType() == null ? it's a matter of style, so as you think..
Line 361: switch (getDisk().getVmEntityType()) {
Line 362: case VM:
Line 363: return createSharedLocksForVmDisk();
Line 364: case TEMPLATE:
--
To view, visit http://gerrit.ovirt.org/16326
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcce291f0e410d5d603c45cb9f9cf21c740de2f1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
