Alon Bar-Lev has posted comments on this change.
Change subject: core: i18n splash with branding
......................................................................
Patch Set 1: (4 inline comments)
Nice!
....................................................
File packaging/branding/ovirt.brand/branding.properties
Line 11:
Line 12: # style sheets. (required, but the files can be empty)
Line 13: user_portal_css=user_portal.css
Line 14: web_admin_css=web_admin.css
Line 15: splash_css=ovirt-engine-style.css
can we avoid ovirt-engine within name? just use splash.css?
BTW: I never heard the splash term for welcome page... :)
Line 16:
Line 17: # text (optional, this overrides the default messages)
Line 18: messages=messages.properties
Line 19:
Line 17: # text (optional, this overrides the default messages)
Line 18: messages=messages.properties
Line 19:
Line 20: #Splash page layout.
Line 21: splash_layout=splash.properties
where is this file?
Line 22:
Line 23: # version (required, the theme will not be applied without this
property)
....................................................
File packaging/branding/ovirt.brand/messages.properties
Line 42:
Line 43: #splash page main section
Line 44: obrand.splash.section1.main=Portals
Line 45: obrand.splash.section1.row1.text=User Portal
Line 46:
obrand.splash.section1.row1.url=/UserPortal/org.ovirt.engine.ui.userportal.UserPortal/UserPortal.html?locale={0}
oh... I would very like to remove these absolute URIs in favor of relative
ones... part of URI rework.
Line 47: obrand.splash.section1.row2.text=Administrator Portal
Line 48:
obrand.splash.section1.row2.url=/webadmin/webadmin/WebAdmin.html?locale={0}
Line 49: obrand.splash.section1.row3.text=Reports Portal
Line 46:
obrand.splash.section1.row1.url=/UserPortal/org.ovirt.engine.ui.userportal.UserPortal/UserPortal.html?locale={0}
Line 47: obrand.splash.section1.row2.text=Administrator Portal
Line 48:
obrand.splash.section1.row2.url=/webadmin/webadmin/WebAdmin.html?locale={0}
Line 49: obrand.splash.section1.row3.text=Reports Portal
Line 50:
obrand.splash.section1.row3.url=/OvirtEngineWeb/RedirectServlet?Page=Reports
I would have dropped the raw and leave only the index, so like ASN.1 you have
multiple instances of same object, and be able to iterate over until there are
none.
--
To view, visit http://gerrit.ovirt.org/16359
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9987ed58c2e0ead9b25c5f46fb974a96bfd46d30
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
