Yaniv Bronhaim has posted comments on this change.
Change subject: Modifying Add\Edit Host popup view
......................................................................
Patch Set 9: (6 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
Line 820: // Save changes.
Line 821: host.setVdsName((String) model.getName().getEntity());
Line 822: host.setHostName((String) model.getHost().getEntity());
Line 823:
host.setPort(Integer.parseInt(model.getPort().getEntity().toString()));
Line 824:
host.setSSHPort(Integer.parseInt(model.getHostPort().getEntity().toString()));
you can't:
String a = "22";
int b = (int)a;
and anyway, all used here Integer.parseInt, so why changing it right now ..
Line 825:
host.setSSHUsername(model.getUserName().getEntity().toString());
Line 826:
host.setSSHKeyFingerprint(model.getFetchSshFingerprint().getEntity().toString());
Line 827: host.setVdsSpmPriority(model.getSpmPriorityValue());
Line 828: boolean consoleAddressSet = (Boolean)
model.getConsoleAddressEnabled().getEntity();
Line 838: host.setPmUser((String) model.getPmUserName().getEntity());
Line 839: host.setPmPassword((String)
model.getPmPassword().getEntity());
Line 840: host.setPmType((String) model.getPmType().getSelectedItem());
Line 841: host.setPmOptionsMap(new
ValueObjectMap(model.getPmOptionsMap(), false));
Line 842:
host.setPmPort(Integer.parseInt(model.getPort().getEntity().toString()));
doesn't related to my patch, i remove that
Line 843:
Line 844: // Save secondary PM parameters.
Line 845: host.setPmSecondaryIp((String)
model.getPmSecondaryIp().getEntity());
Line 846: host.setPmSecondaryUser((String)
model.getPmSecondaryUserName().getEntity());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
Line 974:
ConstantsManager.getInstance().getConstants().errorLoadingFingerprint());
Line 975: }
Line 976: }
Line 977: };
Line 978: getFetchSshFingerprint().setEntity("");
no, i want to clean the field and we fetch the key - its more interactive
Line 979: getFetchResult().setEntity("");
Line 980: getHost().validateEntity(new IValidation[] {
Line 981: new NotEmptyValidation(),
Line 982: new LengthValidation(255),
Line 976: }
Line 977: };
Line 978: getFetchSshFingerprint().setEntity("");
Line 979: getFetchResult().setEntity("");
Line 980: getHost().validateEntity(new IValidation[] {
but validate is called when i click ok, here i want to check the Host field
when i click fetch...
Line 981: new NotEmptyValidation(),
Line 982: new LengthValidation(255),
Line 983: new HostAddressValidation() });
Line 984: if (!getHost().getIsValid()) {
Line 981: new NotEmptyValidation(),
Line 982: new LengthValidation(255),
Line 983: new HostAddressValidation() });
Line 984: if (!getHost().getIsValid()) {
Line 985: getFetchResult().setEntity("Address Error: " +
getHost().getInvalidityReasons().get(0)); //$NON-NLS-1$
where would you put it ?..
Line 986: }
Line 987: else {
Line 988: getFetchResult().setEntity((String)
ConstantsManager.getInstance().getConstants().loadingFingerprint());
Line 989: AsyncDataProvider.getHostFingerprint(aQuery,
getHost().getEntity().toString());
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java
Line 82: @DefaultMessage("Some new hosts are detected in the cluster. You
can <a>Import</a> them to engine or <a>Detach</a> them from the cluster.")
Line 83: String clusterHasNewGlusterHosts();
Line 84:
Line 85: @DefaultMessage("Enter host fingerprint or <a>fetch</a> manually
from host")
Line 86: String fetchingHostFingerprint();
we don't pass ApplicationConstants to edit
--
To view, visit http://gerrit.ovirt.org/16048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e59c8b89da7345733439db95bdb4c729435e372
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
