Allon Mureinik has uploaded a new change for review. Change subject: core: Remove JobIdRowMapper ......................................................................
core: Remove JobIdRowMapper This patch removes JobIdRowMapper and uses the createGuidMapper() method from BaseDAODbFacade, for code-reuse sake. Change-Id: I0e37803c53bff7cfac654408bd2fd317e8a84003 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobSubjectEntityDaoFacadeImpl.java 1 file changed, 1 insertion(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/16388/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobSubjectEntityDaoFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobSubjectEntityDaoFacadeImpl.java index 28d5ddb..f1ab224 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobSubjectEntityDaoFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobSubjectEntityDaoFacadeImpl.java @@ -19,7 +19,6 @@ public class JobSubjectEntityDaoFacadeImpl extends BaseDAODbFacade implements JobSubjectEntityDao { private static JobSubjectEntityRowMapper jobSubjectEntityRowMapper = new JobSubjectEntityRowMapper(); - private static JobIdRowMapper jobIdRowMapper = new JobIdRowMapper(); @Override public void save(Guid jobId, Guid entityId, VdcObjectType entityType) { @@ -53,7 +52,7 @@ MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() .addValue("entity_id", entityId); - return getCallsHandler().executeReadList("GetAllJobIdsByEntityId", jobIdRowMapper, parameterSource); + return getCallsHandler().executeReadList("GetAllJobIdsByEntityId", createGuidMapper(), parameterSource); } private static class JobSubjectEntity { @@ -87,13 +86,4 @@ return entity; } } - - private static class JobIdRowMapper implements RowMapper<Guid> { - - @Override - public Guid mapRow(ResultSet rs, int rowNum) throws SQLException { - return Guid.createGuidFromStringDefaultEmpty(rs.getString(1)); - } - } - } -- To view, visit http://gerrit.ovirt.org/16388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0e37803c53bff7cfac654408bd2fd317e8a84003 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
