Martin Peřina has uploaded a new change for review.

Change subject: core: Adds Kerberos errors to engine log
......................................................................

core: Adds Kerberos errors to engine log

Adds Kerberos error message to engine log when user authentication to
KDC failed.

Change-Id: I6ccca21a70f6e7a683f49884c3c15e45b016ef40
Bug-Url: https://bugzilla.redhat.com/975777
Signed-off-by: Martin Perina <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPIDirContextAuthenticationStrategy.java
1 file changed, 3 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/16401/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPIDirContextAuthenticationStrategy.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPIDirContextAuthenticationStrategy.java
index 70dbb47..9d9f799 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPIDirContextAuthenticationStrategy.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPIDirContextAuthenticationStrategy.java
@@ -141,13 +141,9 @@
             if (result.getAuditLogType() != null) {
                 LdapBrokerUtils.logEventForUser(userName, 
result.getAuditLogType());
             }
-            if (result == AuthenticationResult.OTHER) {
-                // An error our error parser does not recognize
-                log.error("Error from Kerberos: " + ex.getMessage());
-            } else {
-                StringBuilder error = new StringBuilder();
-                error.append(result.getDetailedMessage());
-                log.error(error.toString());
+            log.error("Error from Kerberos: " + ex.getMessage());
+            if (result != AuthenticationResult.OTHER) {
+                log.error(result.getDetailedMessage());
             }
             throw new AuthenticationResultException(result);
         }


-- 
To view, visit http://gerrit.ovirt.org/16401
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ccca21a70f6e7a683f49884c3c15e45b016ef40
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to