Lior Vernia has posted comments on this change.
Change subject: webadmin: Added DC-per-network choice in Discovery popup
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/DiscoverNetworksModel.java
Line 29: private static final String CMD_CANCEL = "Cancel"; //$NON-NLS-1$
Line 30:
Line 31: private final ListModel sourceListModel;
Line 32: private final Provider provider;
Line 33:
Actually, I'm not sure that would be better, even though it's unnecessary. Two
reasons:
1. We tend to not reset (as in re-set) ListModel members, while if I keep this
member as a List<StoragePool> someone is more likely to replace its value
inadvertently in the future.
2. The ListBox column rightfully takes a ListModel as its edit() argument, and
if the model keeps only a List, then the view will create the ListModel upon
call to its edit() method. While not terrible, it's strange for a view to
create a ListModel, isn't it?
Line 34: private ListModel dataCenters = new ListModel();
Line 35: private ListModel networkList = new ListModel();
Line 36:
Line 37: public ListModel getDataCenters() {
--
To view, visit http://gerrit.ovirt.org/15525
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If217cbd8938a81ab0c6c8fed2a12f96b41ad99b8
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
