Alon Bar-Lev has posted comments on this change.
Change subject: network: firewalld: avoid error if not available
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File src/plugins/otopi/network/firewalld.py
Line 139: priority=plugin.Stages.PRIORITY_FIRST,
Line 140: )
Line 141: def _customization(self):
Line 142: if self.services.exists('firewalld'):
Line 143: self._firewalld_version =
self._get_firewalld_cmd_version()
but this way you will end up with uninitialized self._firewalld_version... no?
Line 144: self._enabled = self.environment[
Line 145: constants.NetEnv.FIREWALLD_AVAILABLE
Line 146: ] = (
Line 147: self.services.exists('firewalld') and
--
To view, visit http://gerrit.ovirt.org/16397
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a2617b7b2313e267096ba0b6e878530c97a058e
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
