Mike Kolesnik has posted comments on this change.
Change subject: core: Don't create Guid from String in DAO module
......................................................................
Patch Set 3: I would prefer that you didn't submit this
You missed my comment:
Please note there are some places that you changed new
Guid(rs.getString("...")) to getGuid(rs, "...") which is a change in behaviour
from throwing NPE to not throwing NPE.
Please fix before merging
--
To view, visit http://gerrit.ovirt.org/16392
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f6aec5aa512638c2dbfaa567784f295d01e5ac9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
