Federico Simoncelli has posted comments on this change.
Change subject: [wip] providers: add the openstack image support
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenstackImageProviderProxy.java
Line 80: return DbFacade.getInstance();
Line 81: }
Line 82:
Line 83: @Override
Line 84: public void onAddition() {
This can't go through AddStorageDomain command because the assumption there is
that you need a vds host to do that (which doesn't apply here).
Moreover you shouldn't be allowed to add a glance storage domain
(AddStorageDomain command) because they're maintained by the provider anyway,
and after all we just need an entry in the table.
Line 85: // Storage domain static
Line 86: StorageDomainStatic domainStaticEntry = new
StorageDomainStatic();
Line 87: domainStaticEntry.setId(Guid.newGuid());
Line 88: domainStaticEntry.setStorage(provider.getId().toString());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
Line 84: startProgress(null);
Line 85:
Line 86: AsyncQuery _asyncQuery = new AsyncQuery();
Line 87: _asyncQuery.setModel(this);
Line 88: _asyncQuery.setHandleFailure(true);
Needed because the glance image listing can fail and we need to stop the
progress in the frontend. Not sure why in the ISO it wasn't relevant.
Line 89: _asyncQuery.asyncCallback = new INewAsyncCallback() {
Line 90: @Override
Line 91: public void onSuccess(Object model, Object returnObject)
Line 92: {
--
To view, visit http://gerrit.ovirt.org/15899
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I424998de6f6514d65938484fffa5405e35857e43
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
