Martin Peřina has posted comments on this change.
Change subject: Adding ssh_username and ssh_port to VDS object - VdsStatic
fields
......................................................................
Patch Set 15: (2 inline comments)
I would also use VDS.DEFAULT_SSH_PORT and VDS.DEFAULT_SSH_USERNAME (if agreed
to define them) in all test classes instead of hardcoded values.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
Line 307:
Line 308: // For new registration use default ssh port and user 'root'
Line 309: final int SSH_PORT = 22;
Line 310: final String SSH_USER_NAME = "root";
Line 311:
Wouldn't it be better to define these constants in VDS class?
public class VDS {
public static final int DEFAULT_SSH_PORT = 22;
public static final String DEFAULT_SSH_USERNAME = "root";
Line 312: VdsStatic vds = new
VdsStatic(getParameters().getVdsHostName(), "",
Line 313: getStrippedVdsUniqueId(),
getParameters().getPort(),
Line 314: SSH_PORT,
Line 315: SSH_USER_NAME,
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
Line 104: && ObjectUtils.objectsEqual(vdsGroupGlusterService,
other.vdsGroupGlusterService));
Line 105: }
Line 106:
Line 107: public VDS(Guid vds_group_id, String vds_group_name, String
vds_group_description, Guid vds_id, String vds_name,
Line 108: String ip, String host_name, int port, int ssh_port,
String ssh_username, int status, Integer cpu_cores, Integer cpuThreads, String
cpu_model,
Just a minor thing, I would replace ssh_port to sshPort and ssh_username to
sshUsername. Underscore characters are usually used only for attributes with
static final modifiers.
Line 109: String hwManufacturer, String hwProductName,
Line 110: String hwVersion, String hwSerialNumber, String hwUUID,
String hwFamily,
Line 111: Double cpu_speed_mh, String if_total_speed, Boolean
kvm_enabled, Integer physical_mem_mb,
Line 112: Double cpu_idle, Double cpu_load, Double cpu_sys,
--
To view, visit http://gerrit.ovirt.org/16096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2c38d23faadc4dbed65d08298e0862c5bea26dd
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
