Lior Vernia has posted comments on this change.
Change subject: webadmin: Added HorizontalSplitTable widget
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java
Line 86:
Line 87: @SuppressWarnings("unchecked")
Line 88: @Override
Line 89: public void onClick(ClickEvent event) {
Line 90: if (!button.isEnabled()) {
You are correct, removed the check.
Line 91: return;
Line 92: }
Line 93:
Line 94: MultiSelectionModel<EntityModel> sourceSelectionModel =
Line 90: if (!button.isEnabled()) {
Line 91: return;
Line 92: }
Line 93:
Line 94: MultiSelectionModel<EntityModel> sourceSelectionModel =
Done
Line 95: (button == downButton) ? topSelectionModel :
bottomSelectionModel;
Line 96: EntityModelCellTable<ListModel> sourceTable = (button
== downButton) ? topTable : bottomTable;
Line 97: EntityModelCellTable<ListModel> targetTable = (button
== downButton) ? bottomTable : topTable;
Line 98:
--
To view, visit http://gerrit.ovirt.org/16033
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47b79ed09b69980ef763fecade0940bab0d517ec
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
