Michael Pasternak has posted comments on this change.
Change subject: [WIP] API: Adding RSDL for external jobs/steps
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 3199: body:
Line 3200: parameterType: Job
Line 3201: signatures:
Line 3202: - mandatoryArguments: {job.description: 'xs:string'}
Line 3203: optionalArguments: {job.autoCleared: 'xs:boolean'}
all parameters should be in a xml form, i.e auto_cleared
Line 3204: urlparams: {}
Line 3205: headers:
Line 3206: Content-Type: {value: application/xml|json, required: true}
Line 3207: Expect: {value: 201-created, required: false}
Line 3247: signatures: []
Line 3248: urlparams: {}
Line 3249: headers: {}
Line 3250:
Line 3251: - name: /api/jobs{job:id}/steps|rel=add
missing slash
Line 3252: request:
Line 3253: body:
Line 3254: parameterType: Step
Line 3255: signatures:
Line 3252: request:
Line 3253: body:
Line 3254: parameterType: Step
Line 3255: signatures:
Line 3256: - mandatoryArguments: {step.stepType: 'xs:string' ,
step.description: 'xs:string', step.status: 'xs:string'}
same, xml form ...
btw why not just "type"? you already in context of step ...
Line 3257: optionalArguments: {step.job: ???, step.parentStep: ???}
Line 3258: urlparams: {}
Line 3259: headers:
Line 3260: Content-Type: {value: application/xml|json, required: true}
Line 3253: body:
Line 3254: parameterType: Step
Line 3255: signatures:
Line 3256: - mandatoryArguments: {step.stepType: 'xs:string' ,
step.description: 'xs:string', step.status: 'xs:string'}
Line 3257: optionalArguments: {step.job: ???, step.parentStep: ???}
it depends how you refer/describe relation, by id i guess:
optionalArguments: {step.job.id: 'xs:string', step.parent_step.id: 'xs:string'
btw why do you need a step.job.id here? - you already in context of the job ...
Line 3258: urlparams: {}
Line 3259: headers:
Line 3260: Content-Type: {value: application/xml|json, required: true}
Line 3261: Expect: {value: 201-created, required: false}
Line 3266: body:
Line 3267: parameterType: Action
Line 3268: signatures:
Line 3269: - mandatoryArguments: {}
Line 3270: optionalArguments: {action.force: 'xs:boolean',
action.status: ???}
in /api/jobs{job:id}/steps|rel=add you have used 'xs:string' ...
Line 3271: urlparams: {}
Line 3272: headers:
Line 3273: Content-Type: {value: application/xml|json, required: true}
Line 3274: Correlation-Id: {value: 'any string', required: false}
--
To view, visit http://gerrit.ovirt.org/16171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If39dacf559df5c5a16016069aff3c2f979cc0201
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
