Liron Ar has posted comments on this change. Change subject: core: Fix NPE when committing a snapshot. ......................................................................
Patch Set 2: @Maor - there were 3-4 days between the causing patch was merged to your fix, do we really want to keep this table for all time without those FK because of those few days? regardless, the user can't work with those snapshots, so you can possibly threat it as well in your upgrade script (before adding the FK). -- To view, visit http://gerrit.ovirt.org/16457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If423dd90739cd14a66a7a62399f56465a2e30021 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
