Alon Bar-Lev has posted comments on this change.
Change subject: core: host-deploy: Wrap validation of fingerprint using
EngineSSHClient
......................................................................
Patch Set 16: (3 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHClient.java
Line 1
shouldn't this be renamed?
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java
Line 190: }
Line 191:
Line 192: public long getSoftTimeout() {
Line 193: return _softTimeout;
Line 194: }
do we need this?
Line 195:
Line 196: /**
Line 197: * Set hard timeout.
Line 198: * Hard timeout is maximum duration of session.
Line 203: }
Line 204:
Line 205: public long getHardTimeout() {
Line 206: return _hardTimeout;
Line 207: }
do we need this?
Line 208:
Line 209: /**
Line 210: * Disconnect session.
Line 211: */
--
To view, visit http://gerrit.ovirt.org/16126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01517a153406c8bafc672c20b0bf8686763a2f5
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
