Liron Ar has posted comments on this change. Change subject: core: Add MoveImageGroup to MoveImageGroupCommand ......................................................................
Patch Set 2: I don't agree with this change, MoveImageGroup is an internal command, which executes 2 operations: 1. copy 2. delete Currently, the move command supports execution of the copy with collapse and without collapse. I don't see a reason to add code which reduces the command flexibility, each programmer that uses it can chose to call it with collapse or without collapse...that's my 2 cents on it. -- To view, visit http://gerrit.ovirt.org/16532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf34e2b6c3c33dd86fe4b4243c86b01cd1b19f7c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
