Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: setup: allow invalid fqdn in non interactive mode ......................................................................
packaging: setup: allow invalid fqdn in non interactive mode in interactive mode we allow user to retry and correct invalid host name, in non interactive mode we simply fail installation. there are two reasons why we should not fail installation: 1. in upgrade we need to accept whatever host name existed during setup. this is easy to solve by activating validation only for setup. 2. user who specify host name via cmd-line should know what he is doing, we cannot enforce our decision over. this change will produce error during non interactive setup, but will allow setup to continue. Change-Id: Ic6c80ac47d55ade01dd6a3472e950d2c0ffa0074 Signed-off-by: Alon Bar-Lev <[email protected]> Reported-By: Michael Pasternak <[email protected]> --- M packaging/setup/plugins/ovirt-engine-setup/config/hostname.py 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/16543/1 diff --git a/packaging/setup/plugins/ovirt-engine-setup/config/hostname.py b/packaging/setup/plugins/ovirt-engine-setup/config/hostname.py index e3b94e4..c149717 100644 --- a/packaging/setup/plugins/ovirt-engine-setup/config/hostname.py +++ b/packaging/setup/plugins/ovirt-engine-setup/config/hostname.py @@ -343,14 +343,14 @@ ) validFQDN = True except RuntimeError as e: - if interactive: - self.logger.error( - _('FQDN is not valid: {error}').format( - error=e - ) - ) - else: - raise + self.logger.error( + _('Host name is not valid: {error}').format( + error=e, + ), + ) + self.logger.debug('exception', exc_info=True) + if not interactive: + break # vim: expandtab tabstop=4 shiftwidth=4 -- To view, visit http://gerrit.ovirt.org/16543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6c80ac47d55ade01dd6a3472e950d2c0ffa0074 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
