Federico Simoncelli has posted comments on this change.

Change subject: [wip] frontend: add glance storage domain support
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java
Line 20:     }
Line 21: 
Line 22:     @Override
Line 23:     public String render(T size) {
Line 24:         if (size == null || size.longValue() == 0) {
If the size is > 0 then "< 1 GB" will be displayed. This change is only for 
those entities that expose a size of 0 (unknown). Regular disks for as much as 
they can be small they'll never be 0.
Line 25:             return "NA"; //$NON-NLS-1$
Line 26:         }
Line 27: 
Line 28:         long sizeInGB = -1;


-- 
To view, visit http://gerrit.ovirt.org/15898
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07274bbc14e52471242935fcf99b510469ec4abe
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to