Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: Removed unnecessary DB defaults
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File backend/manager/tools/dbutils/common.sh
Line 11:
Line 12: # When running in development environments the .pgpass file may not
Line 13: # exist or might not be readable, so we should try to use the file
Line 14: # stored in the home directory of the user instead:
Line 15: PGPASSFILE="${ENGINE_PGPASS:-/etc/ovirt-engine/.pgpass}"
I almost sure we overwrote this everywhere at scripts, skipping this logic
entirely. So now you should go over the other script and remove this from there.
Line 16: if [ ! -r "${PGPASSFILE}" ]
Line 17: then
Line 18: PGPASSFILE="${HOME}/.pgpass"
Line 19: fi
Line 14
Line 15
Line 16
Line 17
Line 18
this I do not accept, we should not fallback, when we overwrote this afterwards
I did not care, but now if we do not have ENGINE_PGPASS we get ~/.pgpass which
is incorrect.
Line 17: then
Line 18: PGPASSFILE="${HOME}/.pgpass"
Line 19: fi
Line 20: export PGPASSFILE
Line 21:
this is not needed.
Line 22: }
--
To view, visit http://gerrit.ovirt.org/16469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib20a80aff04ac5f977b55ee9a5e71607292ea8ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
