Alon Bar-Lev has posted comments on this change.
Change subject: core: host-deploy: Using ssh username and password to install
and update host
......................................................................
Patch Set 22: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 218: * tick.
Line 219: */
Line 220: private final Callable<?>[] _customizationDialog = new
Callable<?>[] {
Line 221: new Callable<Object>() { @Override
Line 222: public Object call() throws Exception {
please reformat to match the original, the extra lines are just a waste.
Line 223: _parser.cliEnvironmentSet(
Line 224: "OVIRT_ENGINE/correlationId",
Line 225: _correlationId
Line 226: );
Line 477: * This is tick based vector, every event execute the next
Line 478: * tick.
Line 479: */
Line 480: private final Callable<?>[] _terminationDialog = new
Callable<?>[] {
Line 481: new Callable<Object>() { @Override
same
Line 482: public Object call() throws Exception {
Line 483: _resultError = (Boolean)_parser.cliEnvironmentGet(
Line 484: BaseEnv.ERROR
Line 485: );
Line 580: }
Line 581: return null;
Line 582: }},
Line 583: new Callable<Object>() { @Override
Line 584: public Object call() throws Exception {
same
Line 585: _parser.cliEnvironmentSet(
Line 586: CoreEnv.LOG_REMOVE_AT_EXIT,
Line 587: true
Line 588: );
--
To view, visit http://gerrit.ovirt.org/16006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39914e1286870373ad6f69360fa7b3ddfabd8df
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
