Eli Mesika has posted comments on this change.
Change subject: packaging: setup: changed PGPASSFILE usage in db validations
......................................................................
Patch Set 10: (2 inline comments)
....................................................
File backend/manager/tools/dbutils/fkvalidator.sh
Line 24: source ./common.sh
Line 25:
Line 26: #setting defaults
Line 27: set_defaults
Line 28: ENGINE_PGPASS=${ENGINE_PGPASS:-/etc/ovirt-engine/.pgpass}
Why not setting that once in common.sh:set_defaults ???
Line 29:
Line 30:
Line 31: usage() {
Line 32: printf "Usage: ${ME} [-h] [-s SERVERNAME [-p PORT]] [-d DATABASE]
[-u USERNAME] [-l LOGFILE] [-f] [-q] [-v]\n"
....................................................
File backend/manager/tools/dbutils/taskcleaner.sh
Line 22:
Line 23:
Line 24: #setting defaults
Line 25: set_defaults
Line 26: ENGINE_PGPASS=${ENGINE_PGPASS:-/etc/ovirt-engine/.pgpass}
Why not setting that once in common.sh:set_defaults ???
Line 27:
Line 28: usage() {
Line 29: printf "Usage: ${ME} [-h] [-s server] [-p PORT]] [-d DATABASE] -u
USERNAME [-l LOGFILE] [-t taskId] [-c commandId] [-z] [-R] [-C] [-J] [-A] [-q]
[-v]\n"
Line 30: printf "\n"
--
To view, visit http://gerrit.ovirt.org/16469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib20a80aff04ac5f977b55ee9a5e71607292ea8ff
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
