Gilad Chaplik has posted comments on this change.

Change subject: engine: cluster policy db support
......................................................................


Patch Set 4: (7 inline comments)

will upload a new patch in a short time

....................................................
File packaging/dbscripts/cluster_policy_sp.sql
Line 2: 
Line 3: -- General Queries
Line 4: 
Line 5: -- All cluster policies
Line 6: Create or replace FUNCTION GetAllFromClusterPolicys() RETURNS SETOF 
cluster_policies
this is the naming convention of DefaultGenericDaoDbFacade:
"GetAllFrom{0}s", I will add a comment for it.
Line 7: AS $procedure$
Line 8: BEGIN
Line 9:     RETURN QUERY
Line 10:     SELECT *


Line 17: -- Insert
Line 18: Create or replace FUNCTION InsertClusterPolicy(
Line 19:     v_id UUID,
Line 20:     v_name VARCHAR(128),
Line 21:     v_description VARCHAR(4000),    
Done
Line 22:     v_is_locked BOOLEAN,
Line 23:     v_is_default BOOLEAN,
Line 24:     v_custom_properties text)
Line 25: RETURNS VOID


Line 45: -- Update
Line 46: Create or replace FUNCTION UpdateClusterPolicy(
Line 47:     v_id UUID,
Line 48:     v_name VARCHAR(128),
Line 49:     v_description VARCHAR(4000),    
Done
Line 50:     v_is_locked BOOLEAN,
Line 51:     v_is_default BOOLEAN,
Line 52:     v_custom_properties text)
Line 53: RETURNS VOID


Line 76: 
Line 77: -- Cluster Policy Units
Line 78: 
Line 79: -- Get all units per cluster policy id
Line 80: Create or replace FUNCTION GetAllFromClusterPolicyUnitsGet() RETURNS 
SETOF cluster_policy_units
Done
Line 81: AS $procedure$
Line 82: BEGIN
Line 83:     RETURN QUERY
Line 84:     SELECT *


....................................................
File packaging/dbscripts/policy_unit_sp.sql
Line 1: -- Policy units
Line 2: 
Line 3: -- Get All policy units
Line 4: Create or replace FUNCTION GetAllFromPolicyUnits() RETURNS SETOF 
policy_units
nearby future patches contains additional SPs in this file (handling policy 
unit CRUD). so I'll prefer to leave it for now.
Line 5: AS $procedure$
Line 6: BEGIN
Line 7:     RETURN QUERY
Line 8:     SELECT *


....................................................
File packaging/dbscripts/upgrade/03_03_0400_upgrade_cluster_policy.sql
Line 51: CREATE TABLE cluster_policy_units
Line 52: (
Line 53:     cluster_policy_id UUID,
Line 54:     policy_unit_id UUID,
Line 55:     filter_selected BOOLEAN NOT NULL,
Done
Line 56:     filter_sequence INTEGER DEFAULT 0,
Line 57:     function_selected BOOLEAN NOT NULL,
Line 58:     factor INTEGER DEFAULT 1,
Line 59:     balance_selected BOOLEAN,


Line 100: '{
Line 101:   "CpuOverCommitDurationMinutes" : "'|| 
cpu_over_commit_duration_minutes ||'",
Line 102:   "HighUtilization" : "' || high_utilization ||'",
Line 103:   "LowUtilization" : "' || low_utilization ||'"
Line 104: }'    
Done
Line 105: WHERE  selection_algorithm = 2;
Line 106: UPDATE vds_groups
Line 107: SET    cluster_policy_id = 'b4ed2332-a7ac-4d5f-9596-99a439cb2812'
Line 108: WHERE  selection_algorithm = 0


-- 
To view, visit http://gerrit.ovirt.org/16109
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc34c5eba1d68e0650df38053c97e5138de3dfad
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to