Laszlo Hornyak has posted comments on this change.
Change subject: engine: Integrate cluster commands with new arch
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
Line 180: }
Line 181:
Line 182: if (result) {
Line 183: result = validateClusterPolicy();
Line 184: }
just wondering why you moved to the bottom of the validation.
I would keep all the in-memory validation in the front and the db interactions
as the last. (quite insignificant)
Line 185: return result;
Line 186: }
Line 187:
Line 188: @Override
--
To view, visit http://gerrit.ovirt.org/16605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdd7bbfd825605de8c65bd8dcb7feeef431703ae
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
