Michael Pasternak has posted comments on this change.
Change subject: engine: add comment field to Storage [5]
......................................................................
Patch Set 14: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 865: storagedomain.storage.logical_unit--COLLECTION:
{logical_unit.address: 'xs:string',
Line 866: logical_unit.port: 'xs:int', logical_unit.target:
'xs:string', logical_unit.username: 'xs:string', logical_unit.password:
'xs:string',
Line 867: logical_unit.serial: 'xs:string', logical_unit.vendor_id:
'xs:string', logical_unit.product_id: 'xs:string',
Line 868: logical_unit.lun_mapping: 'xs:int', logical_unit.portal:
'xs:string', logical_unit.paths: 'xs:int', logical_unit.id: 'xs:string'}}
Line 869: optionalArguments: {storagedomain.name: 'xs:string',
storagedomain.comment: 'xs:string', storagedomain.storage.override_luns:
'xs:boolean', storagedomain.storage_format: 'xs:string'}
this property is relevant for all overloads of add()
Line 870: - mandatoryArguments: {storagedomain.host.id|name: 'xs:string',
Line 871: storagedomain.type: 'xs:string',
storagedomain.storage.type: 'xs:string',
Line 872: storagedomain.format:
'xs:boolean',storagedomain.storage.address: 'xs:string',
Line 873: storagedomain.storage.path: 'xs:string'}
--
To view, visit http://gerrit.ovirt.org/15486
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fd8a1b83ed330c945025f13abf565fd899563e7
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
