Laszlo Hornyak has posted comments on this change.
Change subject: engine: enable balance in new arch
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsLoadBalancer.java
Line 53: log.infoFormat("VdsLoadBalancer: high util: {0}, low
util: {1}, duration: {2}, threashold: {3}",
Line 54: group.gethigh_utilization(),
group.getlow_utilization(),
Line 55: group.getcpu_over_commit_duration_minutes(),
Line 56: Config.<Integer>
GetValue(ConfigValues.UtilizationThresholdInPercent));
Line 57: //
migrationHandler.migrateVMs(loadBalancingAlgorithm.LoadBalance());
^ is this intentional?
looks like beyond this point the VdsLoadBalancer is doing nothing in effect,
but anyway, if this lineis no longer wanted here, I would prefer a delete
Line 58: } else {
Line 59: log.debugFormat("VdsLoadBalancer: Cluster {0} skipped
because no selection algorithm selected.",
Line 60: group.getName());
Line 61: }
--
To view, visit http://gerrit.ovirt.org/16375
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f20928f3be5a04e3cea069d8e254956860758f7
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
