Omer Frenkel has posted comments on this change.
Change subject: core: Replace Remove Unassigned and map it to Other
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
Line 50: // This should be removed in 4.0
Line 51: if (node.InnerText.equals(6)) {
Line 52: node.InnerText = "0";
Line 53: }
Line 54:
remove white space
Line 55: if (node != null) {
Line 56:
_vm.getStaticData().setOsId(osRepository.getOsIdByUniqueName(node.InnerText));
Line 57: }
Line 58: }
....................................................
File
packaging/dbscripts/upgrade/03_03_0400_alter_os_type_unassigned_to_other.sql
Line 1: -- os 0 is Unassigned and 6 is OTHER.
white space
Line 2: -- code-wise the defacto default still remains 0 and it will point to
Other instead to Unassigned
--
To view, visit http://gerrit.ovirt.org/16679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie508a8828caedf4cb8fdf971e14139404f7dded3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
