Laszlo Hornyak has posted comments on this change.
Change subject: engine: policy units logic implementation
......................................................................
Patch Set 8: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java
Line 75: public Pair<List<Guid>, Guid> balance(VDSGroup cluster,
Line 76: List<VDS> hosts,
Line 77: Map<String, String> parameters,
Line 78: ArrayList<String> messages) {
Line 79: log.error("policy unit:" + getName() + "balance is not
implemented");
Some implementations do not override and I think that's fine, but do we need
this error log here?
Line 80: return null;
Line 81: }
Line 82:
Line 83: @Override
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NonePolicyUnit.java
Line 30: public Pair<List<Guid>, Guid> balance(VDSGroup cluster,
Line 31: List<VDS> hosts,
Line 32: Map<String, String> parameters,
Line 33: ArrayList<String> messages) {
Line 34: return null;
This method could be removed, other than the log, the superclass does the same
Line 35: }
--
To view, visit http://gerrit.ovirt.org/16110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib29c4257586654392555b6b3675928f187ab96b9
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
