Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding GetMonitoredCommandsQuery
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(1 inline comment)
Please notice you have a rebase issue here - it depends on an outdated patch -
please check.
Giving +1 here - caching is nice, but should not block the patch, but I do want
to make sure the rebase issue is handled.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetMonitoredCommandsQuery.java
Line 13: }
Line 14:
Line 15: @Override
Line 16: protected void executeQueryCommand() {
Line 17: List<String> result = new ArrayList<String>();
+1 here.
The question is - where will we cache? API part? the claculation at engine side
is IMHO not that expensive.
Anyway, I would not block the patchset on this.
Line 18: for (VdcActionType actionType : VdcActionType.values()) {
Line 19: if (actionType.isActionMonitored()) {
Line 20: result.add(actionType.name());
Line 21: }
--
To view, visit http://gerrit.ovirt.org/15231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9ce0d9ddc2bf93c43e0ec55c88e17a9f79eed80
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
