Sahina Bose has posted comments on this change.
Change subject: core: DB, DAO and related BE patch for external..
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File packaging/dbscripts/job_sp.sql
Line 477: DELETE FROM job
Line 478: WHERE (is_auto_cleared
Line 479: AND end_time < v_succeeded_end_time
Line 480: AND status = 'FINISHED')
Line 481: OR (end_time < v_failed_end_time
I think the brackets are placed wrong. The auto_cleared check will not be
applied to the OR block here. Should be
WHERE is_auto_cleared
AND (end_time < v_succeeded_end_time
AND status = 'FINISHED')
OR (end_time < v_failed_end_time
AND status IN ('FAILED', 'ABORTED', 'UNKNOWN'));
Line 482: AND status IN ('FAILED', 'ABORTED', 'UNKNOWN'));
Line 483: END; $procedure$
Line 484: LANGUAGE plpgsql;
Line 485:
--
To view, visit http://gerrit.ovirt.org/15221
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04a2d92fecd43d218f82e39c3a85f27cd3fad1e8
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
