Sahina Bose has posted comments on this change.
Change subject: core: CommandBase modifications
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1954: */
Line 1955: public Map<String, String> getJobMessageProperties() {
Line 1956: jobProperties = new HashMap<>();
Line 1957: List<PermissionSubject> subjects =
getPermissionCheckSubjects();
Line 1958: if (jobProperties == null && subjects != null &&
!subjects.isEmpty()) {
This block of code will never get executed
Line 1959: VdcObjectType entityType;
Line 1960: Guid entityId;
Line 1961: String value;
Line 1962: for (PermissionSubject permSubject : subjects) {
--
To view, visit http://gerrit.ovirt.org/15220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6350853f66e8f117dc3ebf8ff3e346bb9b241ad
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
