Yaniv Bronhaim has posted comments on this change.

Change subject: core: host-deploy: Using ssh username and password to install 
and update host
......................................................................


Patch Set 6: (1 inline comment)

Thanks!

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
Line 859:         {
Line 860:             AddVdsActionParameters parameters = new 
AddVdsActionParameters();
Line 861:             parameters.setVdsId(host.getId());
Line 862:             parameters.setvds(host);
Line 863:             parameters.setPassword((String) 
model.getRootPassword().getEntity());
the following ui patch already do that
Line 864:             parameters.setOverrideFirewall((Boolean) 
model.getOverrideIpTables().getEntity());
Line 865:             parameters.setRebootAfterInstallation(isVirt) ;
Line 866: 
Line 867:             Frontend.RunAction(VdcActionType.AddVds, parameters,


-- 
To view, visit http://gerrit.ovirt.org/16686
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9b23771314ebebb3e10686decb4f0d5ace6d3c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to