Maor Lipchuk has posted comments on this change.
Change subject: core: VmReplicateDiskStart - catch exception on revertTask
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java
Line 81: VDSCommandType.VmReplicateDiskFinish,
migrationStartParams);
Line 82: if (!ret.getSucceeded()) {
Line 83: getEnclosingCommand().preventRollback();
Line 84: }
Line 85: } catch (RuntimeException e) {
If we got timeout exception the operation could still succeed in VDSM.
Probably it worth to add in another patch an audit log for the user that
describe the situation.
Line 86: getEnclosingCommand().preventRollback();
Line 87: }
Line 88: }
Line 89:
--
To view, visit http://gerrit.ovirt.org/16797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50dfae1e3903e6fabb8e8f17c9251977d7b2c874
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
