Michael Pasternak has posted comments on this change.

Change subject: API: host-deploy: Adding ssh username, port and fingerprint to 
host information
......................................................................


Patch Set 9: (2 inline comments)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 1548:         <xs:extension base="BaseResource">
Line 1549:           <xs:sequence>
Line 1550:             <xs:element name="port" type="xs:int" minOccurs="0" 
maxOccurs="1"/>
Line 1551:             <xs:element name="fingerprint" type="xs:string" 
minOccurs="0" maxOccurs="1"/>
Line 1552:             <xs:element ref="authentication_type" minOccurs="0" 
maxOccurs="1"/>
you also need to describe the AutType enum in the BackendCapabilitiesResource
Line 1553:             <xs:element ref="user" minOccurs="0" maxOccurs="1"/>
Line 1554:           </xs:sequence>
Line 1555:         </xs:extension>
Line 1556:       </xs:complexContent>


....................................................
Commit Message
Line 3: AuthorDate: 2013-07-07 14:28:05 +0300
Line 4: Commit:     Yaniv Bronhaim <[email protected]>
Line 5: CommitDate: 2013-07-14 12:18:50 +0300
Line 6: 
Line 7: API: host-deploy: Adding ssh username, port and fingerprint to host 
information
please add/describe this feature in the FeaturesHelper
Line 8: 
Line 9: Those additional fields are used to authenticate with the host during
Line 10: deploy process. Currently we use default port (22) and root user to
Line 11: connect to host. This patch adds the capability to use configurable


-- 
To view, visit http://gerrit.ovirt.org/16685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic18e91f1602af42e7c73acea5d875c54545cb3c2
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to