Giuseppe Vallarelli has posted comments on this change.
Change subject: engine: Remove vnic profiles of a removed a data-center
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Asking a question.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
Line 87: MacPoolManager.getInstance().freeMacs(macsToRemove);
Line 88: setSucceeded(true);
Line 89: }
Line 90:
Line 91: private void removeNetworks() {
Do you plan to add any functional tests for this behaviour? (I don't know about
the common testing practices of the engine)
Line 92: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Line 93:
Line 94: @Override
Line 95: public Void runInTransaction() {
--
To view, visit http://gerrit.ovirt.org/16789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb399dc916983780be9895278e9335e3631ad1cd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
