Michael Pasternak has posted comments on this change.
Change subject: restapi: RFE-Adding External Tasks Support
......................................................................
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StepMapper.java
Line 43: public static org.ovirt.engine.core.common.job.Step map(Step step,
Line 44: org.ovirt.engine.core.common.job.Step entity) {
Line 45: org.ovirt.engine.core.common.job.Step target =
Line 46: entity != null ? entity : new
org.ovirt.engine.core.common.job.Step();
Line 47: target.setId(new Guid(step.getId()));
you still using 'new Guid()' here!, please use GuidUtils instead
Line 48: if (step.isSetParentStep()) {
Line 49:
target.setParentStepId(GuidUtils.asGuid(step.getParentStep().getId()));
Line 50: }
Line 51: target.setJobId(GuidUtils.asGuid(step.getJob().getId()));
--
To view, visit http://gerrit.ovirt.org/16159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b95a094dc586e6ebbdacd44e0a034e91601952
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
