Alon Bar-Lev has posted comments on this change.
Change subject: oVirt Node Upgrade: Support N configuration
......................................................................
Patch Set 13: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
Line 65:
isoData.setVdsmCompitibilityVersion(readVdsmCompatibiltyVersion((
Line 66:
versionFile.getAbsolutePath().replace(OVIRT_ISO_VERSION_PREFIX,
Line 67:
OVIRT_ISO_VDSM_COMPATIBILITY_PREFIX))));
Line 68:
Line 69: if (StringUtils.isEmpty(isoVersionText)) {
isEmpty.
Line 70: log.infoFormat("Iso version file {0} is
empty.", versionFile.getAbsolutePath());
Line 71: continue;
Line 72: }
Line 73:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
Line 80:
Line 81: @Override
Line 82: protected boolean canDoAction() {
Line 83: if (getVdsId() == null || getVdsId().equals(Guid.Empty)) {
Line 84: return validate(new
ValidationResult(VdcBllMessages.VDS_INVALID_SERVER_ID));
I don't know, there was UT exactly for this... So I added this test, I can
remove the UT.
Line 85: }
Line 86: if (getVds() == null) {
Line 87: return validate(new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NOT_EXIST));
Line 88: }
Line 104: String.format("$IsoVersion %1$s",
ovirtHostOsVersion.getMajor())
Line 105: ));
Line 106: }
Line 107:
Line 108: _iso = iso;
Do you suggest to locate the iso again at execute? calling resolveISO()?
Line 109: }
Line 110: return validate(ValidationResult.VALID);
Line 111: }
Line 112:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeInfo.java
Line 22: this.path = path;
Line 23: this.minimumVersion = minimumVersion;
Line 24: }
Line 25:
Line 26: public static List<OVirtNodeInfo> get() {
ok, I think it is over complex.
Line 27: final String delimiter = ":";
Line 28: final String[] path =
Config.resolveOVirtISOsRepositoryPath().split(delimiter);
Line 29: final String minimumVersion[] = Config.<String>
GetValue(ConfigValues.OvirtInitialSupportedIsoVersion).split(delimiter);
Line 30:
--
To view, visit http://gerrit.ovirt.org/14756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
