Allon Mureinik has posted comments on this change.
Change subject: engine: watchdog query cleanup
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetWatchdogQuery.java
Line 27: watchdog.setAction(VmWatchdogAction.getByName((String)
device.getSpecParams().get("action")));
Line 28: watchdog.setModel(VmWatchdogType.getByName((String)
device.getSpecParams().get("model")));
Line 29: watchdog.setVmId(getParameters().getId());
Line 30: watchdog.setId(device.getDeviceId());
Line 31: setReturnValue(Collections.singletonList(watchdog));
queries are supposed to return their results with
getReturnValue().setQueryReturnValue(value)
Line 32: getQueryReturnValue().setSucceeded(true);
Line 33: } else {
Line 34: setReturnValue(Collections.emptyList());
Line 35: getQueryReturnValue().setSucceeded(true);
--
To view, visit http://gerrit.ovirt.org/16622
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8ec62119a2e2aeab5c0e5e140cf15e2a68d3b53
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
