Yair Zaslavsky has posted comments on this change.
Change subject: core: host-deploy: Adding ssh_username and ssh_port to VDS
object - VdsStatic fields
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
Line 305: private boolean registerNewHost(Guid vdsGroupId, boolean
IsPending) {
Line 306: boolean returnValue = true;
Line 307:
Line 308: // For new registration use default ssh port and user 'root'
Line 309: final int SSH_PORT = 22;
please define as private static final int SSH_PORT, and put the constant (this
and SSH_USER_NAME) in top of the class.
Line 310: final String SSH_USER_NAME = "root";
Line 311:
Line 312: VdsStatic vds = new
VdsStatic(getParameters().getVdsHostName(), "",
Line 313: getStrippedVdsUniqueId(),
getParameters().getPort(),
--
To view, visit http://gerrit.ovirt.org/16684
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia968dbb669f997dd7eb51e618270110aacbf50b3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
