Maor Lipchuk has posted comments on this change.
Change subject: backend,webadmin: Enable virtual drive size extension
......................................................................
Patch Set 14: (4 inline comments)
partial reviewed
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
Line 65: }
Line 66:
Line 67: @Override
Line 68: protected Map<String, Pair<String, String>> getSharedLocks() {
Line 69: Map<String, Pair<String, String>> sharedLock = new
HashMap<String, Pair<String, String>>();
You can use diamond operator
Line 70: List<VM> vmsDiskPluggedTo = getVmsDiskPluggedTo();
Line 71:
Line 72: for (VM vm : vmsDiskPluggedTo) {
Line 73: sharedLock.put(vm.getId().toString(),
Line 77: }
Line 78:
Line 79: @Override
Line 80: protected Map<String, Pair<String, String>> getExclusiveLocks() {
Line 81: Map<String, Pair<String, String>> exclusiveLock = new
HashMap<String, Pair<String, String>>();
same as last comment
Line 82: List<VM> vmsDiskPluggedTo = getVmsDiskPluggedTo();
Line 83:
Line 84: if (getNewDisk().isBoot()) {
Line 85: for (VM vm : vmsDiskPluggedTo) {
Line 540: return params;
Line 541: }
Line 542:
Line 543: private void propagateInternalCommandFailure(VdcReturnValueBase
internalReturnValue) {
Line 544: getReturnValue().getExecuteFailedMessages().clear();
why clearing the failures?
Line 545:
getReturnValue().getExecuteFailedMessages().addAll(internalReturnValue.getExecuteFailedMessages());
Line 546: getReturnValue().setFault(internalReturnValue.getFault());
Line 547: getReturnValue().getCanDoActionMessages().clear();
Line 548:
getReturnValue().getCanDoActionMessages().addAll(internalReturnValue.getCanDoActionMessages());
Line 543: private void propagateInternalCommandFailure(VdcReturnValueBase
internalReturnValue) {
Line 544: getReturnValue().getExecuteFailedMessages().clear();
Line 545:
getReturnValue().getExecuteFailedMessages().addAll(internalReturnValue.getExecuteFailedMessages());
Line 546: getReturnValue().setFault(internalReturnValue.getFault());
Line 547: getReturnValue().getCanDoActionMessages().clear();
why clearing the CDA?
Line 548:
getReturnValue().getCanDoActionMessages().addAll(internalReturnValue.getCanDoActionMessages());
Line 549:
getReturnValue().setCanDoAction(internalReturnValue.getCanDoAction());
Line 550: }
--
To view, visit http://gerrit.ovirt.org/14975
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie702348a68a26ac02a01f66aaa1ea42c2c675ebb
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: A Burden <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
