Roy Golan has posted comments on this change.
Change subject: core: osinfo - Remove Unassigned and map it to Other
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/OsTypeUtils.java
Line 19: for (String uniqueName :
osRepository.getUniqueOsNames().values()) {
Line 20: osTypeValues.add(uniqueName);
Line 21: }
Line 22: for (OsType type : OsType.values()) {
Line 23: osTypeValues.add(type.value().toLowerCase());
Done
Line 24: }
Line 25: }
Line 26:
Line 27: private OsTypeUtils() {
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
Line 307: entity.getKernelParams() != null) {
Line 308: OperatingSystem os = new OperatingSystem();
Line 309:
Line 310:
os.setType(SimpleDependecyInjector.getInstance().get(OsRepository.class).getUniqueOsNames().get(entity.getVmOsId()));
Line 311:
other is indeed unique or I didn't get the question
Line 312: os.setKernel(entity.getKernelUrl());
Line 313: os.setInitrd(entity.getInitrdUrl());
Line 314: os.setCmdline(entity.getKernelParams());
Line 315: model.setOs(os);
--
To view, visit http://gerrit.ovirt.org/16679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie508a8828caedf4cb8fdf971e14139404f7dded3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
