Tal Nisan has posted comments on this change.
Change subject: core: Allow force re-election of a specific host as SPM
......................................................................
Patch Set 4: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ReinitializeSPMCommand.java
Line 42: if (getVds().getSpmStatus() != VdsSpmStatus.None) {
Line 43: return
failCanDo(VdcBllMessages.CANNOT_REINIT_SPM_VDS_ALREADY_SPM);
Line 44: }
Line 45:
Line 46: if (getVds().getVdsSpmPriority() ==
BusinessEntitiesDefinitions.HOST_MIN_SPM_PRIORITY) {
Cause if the priority is set to -1 the host is not to be selected as an SPM
Line 47: return
failCanDo(VdcBllMessages.CANNOT_REINIT_SPM_VDS_MARKED_AS_NEVER_SPM);
Line 48: }
Line 49:
Line 50: if
(isAsyncTasksRunningOnPool(getParameters().getStoragePoolId())) {
Line 75: }
Line 76:
Line 77: private boolean isAsyncTasksRunningOnPool(Guid storagePoolId) {
Line 78: List<Guid> tasks =
getAsyncTaskDao().getAsyncTaskIdsByStoragePoolId(storagePoolId);
Line 79: return !tasks.isEmpty();
No.
;)
Line 80: }
Line 81:
Line 82: @Override
Line 83: public AuditLogType getAuditLogTypeValue() {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 709: for (VDS vds : allVds) {
Line 710: if (!mTriedVdssList.contains(vds.getId()) &&
!vds.getId().equals(curVdsId)) {
Line 711: if (vds.getId().equals(preferredHost)) {
Line 712: vdsRelevantForSpmSelection.add(0, vds);
Line 713: }
I agree but I'm want the change the implementation in this class to be as
minimal as I can until we have a proper test suite for it
Line 714: else {
Line 715: vdsRelevantForSpmSelection.add(vds);
Line 716: }
Line 717: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 80: VDS_CANNOT_REMOVE_VDS_STATUS_ILLEGAL=Cannot ${action} ${type}. Host is
operational. Please switch Host to Maintenance mode first.
Line 81: VDS_NOT_EXIST=Cannot ${action} ${type}. Internal Error: Host does not
exists in DB.
Line 82: CANNOT_REINIT_SPM_VDS_NOT_UP=Cannot ${action} ${type}. The Host
${VdsName} is not active.
Line 83: CANNOT_REINIT_SPM_VDS_ALREADY_SPM=Cannot ${action} ${type}. The Host
${VdsName} is already SPM or contending.
Line 84: CANNOT_REINIT_SPM_VDS_MARKED_AS_NEVER_SPM=Cannot ${action} ${type}.
The SPM priority of Host ${VdsName} is set to never. This Host cannot be
elected as SPM.
Done
Line 85: CANNOT_REINIT_SPM_STORAGE_POOL_HAS_RUNNING_TASKS=Cannot ${action}
${type}. The Storage Pool has running tasks.
Line 86: VDS_PROTOCOL_ERROR=Internal error: Host protocol error.
Line 87: VDS_RESPONSE_ERROR=Internal error: Host response error
Line 88: VDS_STATUS_NOT_VALID_FOR_STOP=Cannot perform Stop operation, Host has
to be in Maintenance mode in order to be stopped.
--
To view, visit http://gerrit.ovirt.org/16105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab31fc7918b10448b923821547a583f3d6c3fcba
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: A Burden <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
