Laszlo Hornyak has uploaded a new change for review.

Change subject: engine: handle no migratable vms
......................................................................

engine: handle no migratable vms

Handle the case if no vms are migratable from an overloaded vds

Change-Id: I8588f7dc267672aeb6a9d0a3ed506420cc84a041
Signed-off-by: Laszlo Hornyak <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionPolicyUnit.java
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/58/16858/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionPolicyUnit.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionPolicyUnit.java
index 82193b9..2bade5e 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionPolicyUnit.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionPolicyUnit.java
@@ -64,7 +64,11 @@
             return null;
         }
         VDS randomHost = overUtilizedHosts.get(new 
Random().nextInt(overUtilizedHosts.size()));
-        VM vm = getBestVmToMigrate(randomHost.getId(), 
getMigrableVmsRunningOnVds(randomHost.getId()));
+        List<VM> migrableVmsOnRandomHost = 
getMigrableVmsRunningOnVds(randomHost.getId());
+        if(migrableVmsOnRandomHost.isEmpty()) {
+            return null;
+        }
+        VM vm = getBestVmToMigrate(randomHost.getId(), 
migrableVmsOnRandomHost);
 
         List<Guid> underUtilizedHostsKeys = new ArrayList<Guid>();
         for (VDS vds : underUtilizedHosts) {


-- 
To view, visit http://gerrit.ovirt.org/16858
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8588f7dc267672aeb6a9d0a3ed506420cc84a041
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to