Ravi Nori has posted comments on this change.
Change subject: core: Preventing host activation when host is non responsive
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(1 inline comment)
Just a minor comment on equals
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsValidator.java
Line 68: }
Line 69: if (vds.getStatus().equals(VDSStatus.Up)) {
Line 70: return new ValidationResult(VdcBllMessages.VDS_ALREADY_UP);
Line 71: }
Line 72: if (vds.getStatus().equals(VDSStatus.NonResponsive)) {
is it better practice to do the following
if (VDSStatus.NonResponsive.equals(vds.getStatus()))
same for the check above
Line 73: return new
ValidationResult(VdcBllMessages.VDS_NON_RESPONSIVE);
Line 74: }
Line 75: return ValidationResult.VALID;
Line 76: }
--
To view, visit http://gerrit.ovirt.org/16650
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02846c6e1bc780f5b80a9e99c167f49d24c6bc57
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
