Michael Pasternak has posted comments on this change.
Change subject: restapi: backward compatibility for cluster's scheduling policy
......................................................................
Patch Set 16: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
Line 167: @Mapping(from = VDSGroup.class, to = SchedulingPolicy.class)
Line 168: public static SchedulingPolicy map(VDSGroup entity,
SchedulingPolicy template) {
Line 169: SchedulingPolicy model = template != null ? template : new
SchedulingPolicy();
Line 170: if (entity.getClusterPolicyName() != null) {
Line 171: model.setPolicy(entity.getClusterPolicyName());
does entity.getClusterPolicyName()) maintain old naming convention of
VdsSelectionAlgorithm, how can i ensure that by this patch?
Line 172: if (entity.getClusterPolicyProperties() != null &&
!entity.getClusterPolicyProperties().isEmpty()) {
Line 173: model.setThresholds(new SchedulingPolicyThresholds());
Line 174: String lowUtilization =
entity.getClusterPolicyProperties().get(LOW_UTILIZATION);
Line 175: String highUtilization =
entity.getClusterPolicyProperties().get(HIGH_UTILIZATION);
--
To view, visit http://gerrit.ovirt.org/16607
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4edd7313401670ca225b32d19dd7ad961ccd1b6a
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
